Release 1.1.3 #33
Merged
bharatkashyap merged 8 commits intosamagra-comms:release-4.2.0from Aug 9, 2021
Merged
Conversation
bharatkashyap
suggested changes
Aug 5, 2021
projects/uci-console/src/lib/components/conversation-add/conversation-add.component.ts
Outdated
Show resolved
Hide resolved
| }) | ||
| export class UciService extends BaseService { | ||
| BASE_URL = 'https://uci-server.ngrok.samagra.io/admin/v1/'; | ||
| // BASE_URL = 'https://uci-server2.ngrok.samagra.io/admin/v1/'; |
Contributor
There was a problem hiding this comment.
Can remove this from the comments
|
|
||
| ngOnInit() { | ||
| this.user = this.globalService.getUser(); | ||
| console.log('--->>', this.user); |
Contributor
There was a problem hiding this comment.
@manojSRawat - can we remove all console.log statements
bharatkashyap
approved these changes
Aug 9, 2021
Contributor
bharatkashyap
left a comment
bharatkashyap
left a comment
There was a problem hiding this comment.
Looks good to me - save for the console.log statements.
| } | ||
|
|
||
| manualDownload() { | ||
| window.open('https://sunbirddev.blob.core.windows.net/uci/UCI%20_%20ODK%20Instruction%20Manual.pdf', '_blank'); |
Contributor
There was a problem hiding this comment.
This should take it from environment variable.
So that the same code will work for all environments like dev, staging, preprod & prod
There was a problem hiding this comment.
@bharatkashyap @manojSRawat, please check this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.