sync from upstream #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some websites provide really small favicons. Facebook for instance provides a 16x16px favicon which looks really blurry when used on the desktop (Alt-tab, dock etc..). It might be possible to fake the user agent and define the screen resolution within the request to force such websites to give better resolutions (when asked via Firefox directly, Facebook gives 32x32px for instance). In any case, if the website supports og:image, we should try and use that. This gives us a nice high-res icon (325x325px in the face of Facebook).
Bug Fixes and Code Cleanup
[WIP] Favicon downloader: Try to get og:image first
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.