Skip to content

fix(test): Increase timeout values in concurrency tests#775

Merged
samber merged 1 commit intomasterfrom
test-fix-concurrency-check-race
Jan 12, 2026
Merged

fix(test): Increase timeout values in concurrency tests#775
samber merged 1 commit intomasterfrom
test-fix-concurrency-check-race

Conversation

@samber
Copy link
Owner

@samber samber commented Jan 12, 2026

No description provided.

Copilot AI review requested due to automatic review settings January 12, 2026 19:55
@samber samber merged commit a2da397 into master Jan 12, 2026
24 checks passed
@samber samber deleted the test-fix-concurrency-check-race branch January 12, 2026 19:56
@codecov
Copy link

codecov bot commented Jan 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.17%. Comparing base (da54892) to head (73baa64).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #775      +/-   ##
==========================================
- Coverage   94.20%   94.17%   -0.04%     
==========================================
  Files          18       18              
  Lines        2867     2867              
==========================================
- Hits         2701     2700       -1     
- Misses        150      151       +1     
  Partials       16       16              
Flag Coverage Δ
unittests 94.17% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request addresses flaky concurrency tests by increasing timeout values to provide more tolerance for slower execution environments.

Changes:

  • Doubled timeout and heartbeat delay values in the "counter is incremented" test case
  • Updated assertion delta tolerances proportionally to match the new timeout values

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants