perf/reduce allocations#123
Merged
Merged
Conversation
Owner
samber
commented
May 28, 2026
samber
commented
- perf: reduce allocations in hot paths
- fix(lint): add blank line before var declaration for gofmt
- framesToStacktraceBlocks/framesToSourceBlocks now accept []outputBlock directly, removing one intermediate slice allocation per Stacktrace() and Sources() call - fix make(0, len)+index-assign bug in Stacktrace() and StackFrames() (would panic at runtime on non-empty error chains) - reuse frameStr variable in framesToStacktraceBlocks (was calling frame.String() twice per frame) - replace 3x strings.Replace in shortFuncName with a package-level strings.Replacer (one pass, no intermediate string allocations)
Contributor
There was a problem hiding this comment.
Pull request overview
This PR focuses on reducing allocations in stacktrace/source rendering paths for OopsError, and includes a small formatting tweak to satisfy gofmt.
Changes:
- Replaced per-call
strings.Replacechains with a sharedstrings.ReplacerinshortFuncName. - Removed intermediate
lo.Tuple*conversions by passing[]outputBlockdirectly into stacktrace/source block builders. - Reduced allocations in
StackFrames()by pre-sizing the returned[]runtime.Frameand assigning by index.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| stacktrace.go | Uses a shared strings.Replacer, switches block formatting helpers to []outputBlock, and avoids repeated frame.String() calls. |
| error.go | Removes tuple-slice construction for stacktrace/source output and preallocates []runtime.Frame in StackFrames(). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #123 +/- ##
==========================================
+ Coverage 89.30% 89.40% +0.10%
==========================================
Files 15 15
Lines 1159 1161 +2
==========================================
+ Hits 1035 1038 +3
Misses 100 100
+ Partials 24 23 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.