Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands the ttsc shim API surface by exporting additional TypeScript AST/checker types and flags, and adds a new checker helper to retrieve a type’s base types for downstream consumers.
Changes:
- Export additional checker flags/types (
ElementFlags,ObjectFlags*,ElementFlags*) from the checker shim. - Export additional AST types/flags (
TypePredicateParameterName,AssertsKeyword,KindAssertsKeyword,ModifierFlags*) from the AST shim. - Add
Checker_getBaseTypesvia//go:linknameto expose the internal checkergetBaseTypesimplementation with a nil-safe wrapper.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/ttsc/shim/checker/shim.go | Adds ElementFlags exports, additional flag constants, and a Checker_getBaseTypes shim wrapper around an internal checker method. |
| packages/ttsc/shim/ast/shim.go | Exposes additional AST node types and new kind/modifier flag exports in the AST shim. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds several new type and flag exports to the shim layers for the TypeScript compiler's AST and type checker, expanding the available API surface for downstream consumers. It also introduces a new function for retrieving base types from the checker. The most important changes are grouped below:
AST Shim Enhancements
TypePredicateParameterNameandAssertsKeywordtoshim.go, making these AST node types available for consumers.KindAssertsKeyword,ModifierFlagsPrivate,ModifierFlagsProtected, andModifierFlagsReadonly. [1] [2]Type Checker Shim Enhancements
ElementFlagstype and constants such asObjectFlagsClass,ObjectFlagsInterface,ObjectFlagsClassOrInterface,ElementFlagsNone,ElementFlagsRequired,ElementFlagsOptional,ElementFlagsRest, andElementFlagsVariadic. [1] [2]New Checker Utility
Checker_getBaseTypes(and its linked internal implementation) for retrieving the base types of a given type from the checker, improving type introspection capabilities.