Address canadensis_can v0.5.0 memory usage#57
Merged
samcrow merged 6 commits intosamcrow:masterfrom Oct 11, 2025
Merged
Conversation
Owner
|
Thanks for contributing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #55 (to an extent). Adds a few regression tests. Subscriptions now use ~2 KB each (on allocation, with more memory being allocated to store transfer reassemblies as needed); this is still more than I would like and more than v0.3.1 (~0.5 KB) but it is an improvement while handling transfer-ID-related issues properly as best as I can tell.
This adds ServiceId::{MIN, MAX} and SubjectId::{MIN, MAX} public constants to canadensis_core. This is just for the tests; you can add local constant definitions to the test file instead if you'd like to avoid bumping the canadensis_core version.