Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the way JSON deserialization is handled throughout the codebase, replacing usages of
TypeTokenwith array-based deserialization for improved type safety and simplicity. It also includes several minor updates and improvements, such as a version bump, new ProGuard rules, and a debug label for the Essentials tab.Serialization/Deserialization Refactoring:
Replaced
TypeToken-based deserialization with array-based deserialization (Array<T>::class.java) and conversion to lists or sets inSettingsRepository,GitHubRepository,UpdateRepository,BatteryNotificationService, andNotificationListener. This change improves type safety and reduces boilerplate code. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16]Removed unnecessary imports of
TypeTokenin multiple files after the refactor. [1] [2] [3]Build and Configuration Updates:
versionCodeto 30 andversionNameto "11.6" inbuild.gradle.kts.com.sameerasw.essentials.domain.diypackage.Feature and Usability Improvements:
reloadAutomationsmethod inDIYRepositoryto allow reloading automations at runtime.Code and Logic Cleanups:
SettingsRepositoryfor handling preference keys and config import, replacingTypeTokenwith direct casting fromMap::class.java. [1] [2]These changes collectively modernize and simplify the codebase, reduce potential runtime errors from type erasure, and make future maintenance easier.