Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new "Circle to Search" gesture feature, allowing users to trigger the Google "Circle to Search" action via a long-press gesture overlay or as a remappable button action. The implementation includes UI options, persistent settings, gesture handling, and system integration.
Feature: Circle to Search Gesture
circle_to_search_gesture_enabledtoSettingsRepositoryto store user preference for enabling the gesture.OtherCustomizationsSettingsUIfor enabling/disabling the "Circle to Search" gesture, which is only active if the gesture bar is hidden.MainViewModelto manage the state of the new gesture setting and keep it in sync with preferences. [1] [2] [3]Gesture Overlay Implementation
OmniGestureOverlayHandler, a new class that displays an overlay for the gesture, handles long-press detection, and provides haptic feedback. The overlay is shown/hidden based on the relevant settings and device state.ScreenOffAccessibilityService, including lifecycle management, configuration change handling, and reacting to preference changes. [1] [2] [3] [4] [5] [6] [7] [8] [9]Remappable Action Support
ButtonRemapHandlerto support triggering the gesture (with haptic feedback) when this action is selected. [1] [2]System Integration Utility
OmniTriggerUtil, a utility for triggering the Google "Circle to Search" session using reflection and Shizuku, handling both root and non-root scenarios.