[pull] master from netdata:master#125
Merged
pull[bot] merged 8 commits intosamjaninf:masterfrom Jul 20, 2024
Merged
Conversation
* Initial Windows CI support. This also adds a proper set of production-focused packaging scripts for working with building Netdata on Windows. * Pivot to using existing tooling and fixing that up as required. * General script cleanup. * Auto-detect location of repository based on script location. This makes the scripts properly independent of the current working directory, allowing them to be more resilient to possible changes in the build environment. * Make dependency handling entirely separate from build. * Remove development-only packages from dependency list. They only waste time in CI, and it’s reasonable to assume that anybody who needs them can install them themselves, just like we do with all other platforms. * Use absolute path for makensis. This way it actually works without needing manual modification of the environment. * Add PowerShell scripts to invoke the build and package scripts. * Clean up build directory handling. * Fix fetching of msys2 installer. * Further cleanup. * Tidy up build output * Provide proper output grouping in GitHub Actions. * Use correct command name for makensis. * Fix installer script path. * Do not try to install MSYS2 using Chocolatey. * Fix CPU architecture check. * Add more detailed messages for MSYS2 install. * Fix release fetching logic. * Further release check logic fixes. * Complete Windows CI support. * Move second update pass into dependency handling script. * Fix handling of icon for Windows installer. * Default to using a working configuration for release builds. And provide a way to pass extra options to CMake without needing to modify the script. * Fix expansion of optionally defined variable.
In practice, ndsudo is only actually used by the Go plugin, so we only need to build and install it if we are building and installing the Go plugin. This speeds up the build a tiny bit when the Go plugin is not being built, and removes a non-trivial bit of attack surface from the eventual install as well.
Do not include REMOVED status in the snapshot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )