crypto: add OriginSigningKey for the origin key ceremony#14
Merged
Conversation
Deriving an OriginPubkey (and from it the onion address) from an origin seed had no public path: VerifyingKey construction from a seed is crate-private, and there was no origin signing-key type. A publisher ceremony needs seed -> OriginPubkey -> onion. Add OriginSigningKey, matching PublisherSigningKey and RuntimeSigningKey (from_seed, verifying_key), but with no sign method: K_origin never signs documents in v1.0; it exists only so the onion address derives from it and origin.origin_pubkey can be checked against the address. An end-to-end test derives the corpus origin seed through OriginSigningKey -> OriginPubkey -> from_origin_pubkey to the recorded public key and onion address. Additive; crate 0.9.0 -> 0.10.0; Cargo.lock updated; spec revision unchanged (rc.48).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deriving an
OriginPubkey(and from it the onion address) from an origin seed had no public path:VerifyingKeyconstruction from a seed is crate-private, and there was no origin signing-key type. A publisher ceremony needsseed -> OriginPubkey -> onion.Add
OriginSigningKey, matchingPublisherSigningKeyandRuntimeSigningKey(from_seed,verifying_key), but with nosignmethod:K_originnever signs documents in v1.0; it exists only so the onion address derives from it andorigin.origin_pubkeycan be checked against the address. Combine withOnionAddress::from_origin_pubkey(added in #13) for the full ceremony.An end-to-end test derives the corpus origin seed through
OriginSigningKey -> OriginPubkey -> from_origin_pubkeyto the recorded public key and onion address, byte for byte.Additive; crate 0.9.0 -> 0.10.0; Cargo.lock updated. Spec revision unchanged (rc.48). fmt, clippy -D warnings, doc -D warnings, and the full test suite are green with --locked.