Skip to content

adding ujson to reqirements.txt and setup.py#481

Merged
kimchirichie merged 1 commit intosammchardy:masterfrom
oliver-zehentleitner:master
Jan 1, 2021
Merged

adding ujson to reqirements.txt and setup.py#481
kimchirichie merged 1 commit intosammchardy:masterfrom
oliver-zehentleitner:master

Conversation

@oliver-zehentleitner
Copy link
Copy Markdown
Contributor

You added ujson (#383) and its missing in the requirements!

@xiaods
Copy link
Copy Markdown

xiaods commented Apr 25, 2020

please upgrade it. thanks a lot.

@lancechua
Copy link
Copy Markdown
Contributor

Glad to see there's some interest in using a faster JSON library.

I initially wanted it to be an optional requirement as I didn't want to add another dependency. ujson works very well since it has the same API to stdlib json for the most part.

@kimchirichie
Copy link
Copy Markdown
Contributor

is this good to merge? need some verification from crowd before merging

@kimchirichie kimchirichie added the Pending verification pending on at least 2 users testing, and verifying it works label Jan 1, 2021
@oliver-zehentleitner
Copy link
Copy Markdown
Contributor Author

oliver-zehentleitner commented Jan 1, 2021

@kimchirichie
ujson is already used by python-binance, but its missing in setup.py and requirements.txt which is needed to create the package and to install the required dependencies... ujson itself works very well and was added to python-binance code with #383 . we also use ujson in ubwa since a couple of months....

@kimchirichie kimchirichie merged commit 1adc7ef into sammchardy:master Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Pending verification pending on at least 2 users testing, and verifying it works

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants