Skip to content

feat: get task by id#242

Merged
TKussel merged 10 commits into
developfrom
task-by-id
Jul 2, 2026
Merged

feat: get task by id#242
TKussel merged 10 commits into
developfrom
task-by-id

Conversation

@Threated

@Threated Threated commented Jun 6, 2025

Copy link
Copy Markdown
Member

No description provided.

@Threated Threated requested a review from TKussel June 6, 2025 07:36
@Threated Threated force-pushed the task-by-id branch 3 times, most recently from 7b4dbc3 to bafeae2 Compare June 6, 2025 10:28
@TKussel

TKussel commented Jun 6, 2025

Copy link
Copy Markdown
Member

The manual testing worked perfectly! However, before merging it to the baseline, I need to add tests and documentation

@TKussel

TKussel commented Jul 1, 2026

Copy link
Copy Markdown
Member

I added tests and documentation. As I can't select you as a reviewer, I humbly beg ;)

@Threated

Threated commented Jul 1, 2026

Copy link
Copy Markdown
Member Author

CI seems to fail. The one batch due to being old I think (needs rebase) and the other due to test your tests failing it seems

@TKussel TKussel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awaiting your thumbs-up for merging @Threated :)

Comment thread shared/src/lib.rs Outdated
@Threated

Threated commented Jul 2, 2026

Copy link
Copy Markdown
Member Author

LGTM. Can't approve cause its my own PR

@TKussel TKussel merged commit 1661d47 into develop Jul 2, 2026
33 checks passed
@TKussel TKussel deleted the task-by-id branch July 2, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants