Skip to content

feat: ssh tunnel#292

Merged
Threated merged 6 commits into
developfrom
feature/ssh-tunnel
Apr 14, 2025
Merged

feat: ssh tunnel#292
Threated merged 6 commits into
developfrom
feature/ssh-tunnel

Conversation

@Threated
Copy link
Copy Markdown
Member

@Threated Threated commented Apr 14, 2025

No description provided.

@Threated Threated requested a review from TKussel April 14, 2025 07:37
@Threated Threated requested a review from a team as a code owner April 14, 2025 07:37
TKussel
TKussel requested changes Apr 14, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@TKussel TKussel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add documentation to the Readme.md? The usage and its requirements (e.g. non-passcode ssh key) are not self explanatory.

@Threated
Copy link
Copy Markdown
Member Author

Threated commented Apr 14, 2025

Should we really add that documentation to the root level Readme? It does not contain any component specific docs yet. I feel like a markdown document in ccp/modules fits our current structure better (there are already markdown docs explaining some modules). Also I guess we could move this module to the top level modules folder as it is project independent.

@Threated Threated force-pushed the feature/ssh-tunnel branch from cb5debd to b6bd619 Compare April 14, 2025 07:59
@Threated Threated requested a review from TKussel April 14, 2025 08:31
@TKussel
Copy link
Copy Markdown
Member

TKussel commented Apr 14, 2025 •
edited
Loading

True. The markdown documents in */modules are a relict of the past and are discouraged, if I remember correctly (even though I think it is useful in this instance). Moving it to minimal/modules is a good idea.

@Threated
Copy link
Copy Markdown
Member Author

Threated commented Apr 14, 2025

Its actually a top level modules folder (not in minimal/) Torben and I introduced with transfair.

@Threated Threated merged commit 2ddd535 into develop Apr 14, 2025
@Threated Threated deleted the feature/ssh-tunnel branch April 14, 2025 08:45
mmwaikar pushed a commit that referenced this pull request Jan 28, 2026
@Threated @TKussel @mmwaikar
feat: ssh tunnel (#292)
e0c2162 
* Added ccp module for a ssh tunnel

Usage details under https://github.com/samply/ssh-tunnel

* chore: update ssh-tunnel image to harbor

* feat: ssh tunnel support diffrent port

* chore: fix indentation

* chore: move to top level modules

* docs: add ssh-tunnel docs

---------

Co-authored-by: Tobias Kussel <tobias.kussel@dkfz-heidelberg.de>
mmwaikar pushed a commit that referenced this pull request Jan 28, 2026
@Threated @TKussel @mmwaikar
feat: ssh tunnel (#292)
ce16650 
* Added ccp module for a ssh tunnel

Usage details under https://github.com/samply/ssh-tunnel

* chore: update ssh-tunnel image to harbor

* feat: ssh tunnel support diffrent port

* chore: fix indentation

* chore: move to top level modules

* docs: add ssh-tunnel docs

---------

Co-authored-by: Tobias Kussel <tobias.kussel@dkfz-heidelberg.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TKussel TKussel TKussel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Threated @TKussel