Skip to content

Feature/itcc lens2#365

Merged
Threated merged 14 commits into
developfrom
feature/itcc-lens2
Jan 28, 2026
Merged

Feature/itcc lens2#365
Threated merged 14 commits into
developfrom
feature/itcc-lens2

Conversation

@Martin1088
Copy link
Copy Markdown
Contributor

Projekt itcc migration lens 1 -> 2 and API omics Upload data endpoint with endpoint security ApiKey

@Martin1088 Martin1088 requested a review from a team as a code owner December 8, 2025 14:49
@Martin1088 Martin1088 self-assigned this Dec 8, 2025
Comment thread itcc/modules/lens-compose.yml Outdated
Comment on lines +19 to +21
HTTP_PROXY: ${HTTP_PROXY_URL}
HTTPS_PROXY: ${HTTPS_PROXY_URL}
NO_PROXY: beam-proxy
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spot should not need any proxy vars as it's only talking to local components

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete

Comment thread itcc/modules/lens-compose.yml Outdated
container_name: lens_federated-search
image: docker.verbis.dkfz.de/ccp/lens:${SITE_ID}
container_name: lens_itcc_explorer
image: ghcr.io/samply/itcc-explorer:fix-setup
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it correct that this uses a feature branch (and a ghcr image)?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it is now on samply/itcc-explorer:develop also provided

Comment thread itcc/modules/lens-compose.yml Outdated
@@ -1,33 +1,46 @@
version: "3.7"
services:
landing:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it intended that this overrides the config for the default landing page in minimal/docker-compose.yml? If so I am not sure doing it like that is the best idea as this will try to merge the two landing definitions which might result in strange behavior . In the dnpm-node-compose.yml we just did this

landing:
labels:
- "traefik.http.routers.landing.rule=PathPrefix(`/landing`)"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to look with behaviour is intended in future

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • "traefik.http.routers.blaze_itcc.rule=Host(${HOST}) && PathPrefix(/itcc-localdatamanagement)"
  • "traefik.http.routers.itcc.rule=Host(${HOST}) && PathPrefix(/)"
  • "traefik.http.routers.omics.rule=Host(${HOST}) && PathPrefix(/api/omics)"

@Threated Threated merged commit 6923ead into develop Jan 28, 2026
@Threated Threated deleted the feature/itcc-lens2 branch January 28, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants