[codex] Fix vNext keyword memory retrieval#219
Merged
Conversation
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the vNext context-pack retrieval path for committed memories that match the user query by keywords but not as one contiguous phrase. The Postgres store now searches memories and sources with an exact phrase first, then keyword fallback patterns, while preserving the existing domain and sensitivity filters.
Root Cause
search_memories()andsearch_sources()previously built a singleILIKE %query%predicate. Agent queries such asagent-first /vnext audit correction cockpitcould exclude the intended memory before the Python ranker saw it, even though the memory had strong token overlap anddomain=unknownwas allowed by policy.Validation
./.venv/bin/pytest tests/unit/test_vnext_store.py tests/integration/test_vnext_agentic_memory_commit_api.py -q./.venv/bin/python -m py_compile apps/api/src/alicebot_api/vnext_store.pygit diff --check138a27e2-4eec-48e7-b71d-ca10ef57caaewith no retrieval warnings.