Fix vNext memory commit schema aliases#222
Merged
Merged
Conversation
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade Overview
Protected Areas
Compatibility Impact
MCP callers that send canonical vNext memory labels continue to behave the same. Common quote aliases such as memory_type=quote and domain=quotes now normalize to schema-backed values instead of surfacing a Postgres CheckViolation.
Migration / Rollout
No database migration is required. Roll out by deploying the API/MCP code and restarting any long-running alice-core MCP process so agents load the updated schema and validation path.
Operator Action
If an agent previously hit repeated alice_vnext_commit_memory CheckViolation errors, restart the agent or MCP session after deploy and retry with canonical values. For quote saves, use memory_type=semantic and domain=learning.
Validation
Validated locally with the full Python unit suite, the agentic-memory-commit smoke, API health, and whitespace checks.
Rollback
Revert this PR if the MCP enum normalization causes unexpected caller behavior. Existing database rows are unchanged because this patch does not alter persisted schema or run migrations.
Validation