Codegen #13
Merged
Codegen #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mjossdev
approved these changes
May 14, 2023
codegen/src/main/kotlin/tools/samt/codegen/KotlinTypesGenerator.kt
Outdated
Show resolved
Hide resolved
codegen/src/main/kotlin/tools/samt/codegen/kotlin/ktor/KotlinKtorConsumerGenerator.kt
Fixed
Show fixed
Hide fixed
codegen/src/main/kotlin/tools/samt/codegen/kotlin/ktor/KotlinKtorConsumerGenerator.kt
Fixed
Show fixed
Hide fixed
codegen/src/main/kotlin/tools/samt/codegen/kotlin/ktor/KotlinKtorConsumerGenerator.kt
Fixed
Show fixed
Hide fixed
codegen/src/main/kotlin/tools/samt/codegen/kotlin/ktor/KotlinKtorConsumerGenerator.kt
Fixed
Show fixed
Hide fixed
codegen/src/main/kotlin/tools/samt/codegen/kotlin/ktor/KotlinKtorProviderGenerator.kt
Fixed
Show fixed
Hide fixed
codegen/src/main/kotlin/tools/samt/codegen/kotlin/ktor/KotlinKtorProviderGenerator.kt
Fixed
Show fixed
Hide fixed
codegen/src/main/kotlin/tools/samt/codegen/kotlin/ktor/KotlinKtorProviderGenerator.kt
Fixed
Show fixed
Hide fixed
codegen/src/main/kotlin/tools/samt/codegen/kotlin/ktor/KotlinKtorProviderGenerator.kt
Fixed
Show fixed
Hide fixed
codegen/src/main/kotlin/tools/samt/codegen/kotlin/ktor/KotlinKtorProviderGenerator.kt
Fixed
Show fixed
Hide fixed
codegen/src/main/kotlin/tools/samt/codegen/kotlin/ktor/KotlinKtorConsumerGenerator.kt
Fixed
Show fixed
Hide fixed
PascalHonegger
force-pushed
the
codegen
branch
2 times, most recently
from
a01bcf8 to
9062c28
Compare
Also incorporated feedback by @PascalHonegger
Kotlin KTor Generator can use this information to emit parameter loads.
Currently only shown as comment in output, no actual functionality
mjossdev
reviewed
May 30, 2023
Member
mjossdev
left a comment
mjossdev
left a comment
There was a problem hiding this comment.
I got about halfway through will review more later
codegen/src/main/kotlin/tools/samt/codegen/http/HttpTransport.kt
Outdated
Show resolved
Hide resolved
codegen/src/main/kotlin/tools/samt/codegen/kotlin/KotlinTypesGenerator.kt
Show resolved
Hide resolved
mjossdev
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.