Allow Map keys to be a typealias of String #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mjossdev
commented
Jun 3, 2023
mjossdev
commented
- build(shadow): remove version suffix from ls and cli fat jars
- fix(semantic): allow typealiases of String as Map keys again
Member
Author
|
The check was moved to the PostProcessor to ensure that typealiases have been fully resolved |
compiler/src/main/kotlin/tools/samt/semantic/SemanticModelPostProcessor.kt
Outdated
Show resolved
Hide resolved
mjossdev
force-pushed
the
fix-map-key-typealias
branch
from
0b8c52a to
067e144
Compare
KCreate
approved these changes
Jun 3, 2023
PascalHonegger
approved these changes
Jun 3, 2023
mjossdev
force-pushed
the
fix-map-key-typealias
branch
from
f5c5978 to
9a1747b
Compare
PascalHonegger
approved these changes
Jun 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.