AST Dump by KCreate · Pull Request #8 · samtkit/core

KCreate · 2023-03-26T18:31:49Z

Todos

Unit tests for dump format
Colorize output in shells that support colors, disable in shells that don't

lexer/src/main/kotlin/tools/samt/lexer/Lexer.kt

parser/src/main/kotlin/tools/samt/parser/Nodes.kt

parser/src/main/kotlin/tools/samt/parser/ASTPrinter.kt

common/src/main/kotlin/tools/samt/common/Location.kt

parser/src/main/kotlin/tools/samt/parser/ASTPrinter.kt

cli.sh

parser/src/main/kotlin/tools/samt/parser/Nodes.kt

cli/src/main/kotlin/tools/samt/cli/CliArgs.kt

cli/src/main/kotlin/tools/samt/cli/CliCompiler.kt

lexer/src/main/kotlin/tools/samt/lexer/Lexer.kt

common/src/main/kotlin/tools/samt/common/Location.kt

cli/build.gradle.kts

KCreate · 2023-03-31T09:21:35Z

@PascalHonegger Please re-review and merge if satisfied

PascalHonegger · 2023-03-31T09:22:43Z

@KCreate please rebase on main and then mark PR as ready (you could also rename the Make Pascal happy commit in the process)

End is now exclusive Newlines now live in the line they terminate

Removed else handler from when statement. Adding new AST nodes in the future will cause an error to appear here, instead of not working silently.

Per pascals comments

Display the full name written out in the AST dump instead of only the component identifiers. Also changes the method by which BundleIdentifier nodes are validated in the Parser unit tests.

KCreate · 2023-03-31T09:24:18Z

That commit name cannot be changed because it is relevant to the structural integrity of the repository.

cli/src/main/kotlin/tools/samt/cli/CliCompiler.kt

cli/src/test/kotlin/tools/samt/cli/CliCompilerTest.kt

common/src/main/kotlin/tools/samt/common/Location.kt

specification/examples/debug.samt

specification/examples/greeter.samt

File is now actively ignored

KCreate added the enhancement New feature or request label Mar 26, 2023

KCreate requested a review from PascalHonegger March 26, 2023 18:31

KCreate self-assigned this Mar 26, 2023

PascalHonegger requested changes Mar 27, 2023

View reviewed changes

PascalHonegger reviewed Mar 27, 2023

View reviewed changes

parser/src/main/kotlin/tools/samt/parser/Nodes.kt Outdated Show resolved Hide resolved

PascalHonegger reviewed Mar 27, 2023

View reviewed changes

cli/src/main/kotlin/tools/samt/cli/CliArgs.kt Outdated Show resolved Hide resolved

PascalHonegger reviewed Mar 27, 2023

View reviewed changes

cli/src/main/kotlin/tools/samt/cli/CliCompiler.kt Outdated Show resolved Hide resolved

PascalHonegger reviewed Mar 27, 2023

View reviewed changes

lexer/src/main/kotlin/tools/samt/lexer/Lexer.kt Outdated Show resolved Hide resolved

common/src/main/kotlin/tools/samt/common/Location.kt Outdated Show resolved Hide resolved

PascalHonegger mentioned this pull request Mar 30, 2023

Semantic validation #10

Merged

PascalHonegger reviewed Mar 30, 2023

View reviewed changes

cli/build.gradle.kts Outdated Show resolved Hide resolved

KCreate requested a review from PascalHonegger March 31, 2023 09:21

KCreate added 14 commits March 31, 2023 11:23

feat(CLI): Added helper shell script to run CLI

7a2bad4

feat(AST): Dump visual representation of AST

aa03aef

refactor(lexer): Refactored location bookkeeping

b0566ed

End is now exclusive Newlines now live in the line they terminate

refactor(misc): Make Pascal happy

09cb36a

feat(parser): colorize AST dump

05aba1f

refactor(astprinter): removed else handler

f2b5b43

Removed else handler from when statement. Adding new AST nodes in the future will cause an error to appear here, instead of not working silently.

feat(cli): Rename CLI arg --dumpast to --dump-ast

8bc8fa4

refactor(misc): Use KDoc comment instead of line

0ad2314

refactor(gradle): Move mordant dependency line

b186f1b

Per pascals comments

refactor(lexer): Line comment to KDoc

a118b19

Moved mordant dependency to version catalog

c5131cc

refactor(ast): Display bundle identifier full name

8f2ae35

Display the full name written out in the AST dump instead of only the component identifiers. Also changes the method by which BundleIdentifier nodes are validated in the Parser unit tests.

fix(ast): Fix multiline string highlighting in AST dump

7249e9f

test(cli): Added AST dump unit test

c8bd110

KCreate force-pushed the ast-dump branch from 3ec3990 to c8bd110 Compare March 31, 2023 09:23

KCreate marked this pull request as ready for review March 31, 2023 09:24

PascalHonegger reviewed Mar 31, 2023

View reviewed changes

KCreate added 3 commits March 31, 2023 11:45

fix(misc): Incorporate review feedback

f5ebbd8

fix(misc): Fixed Qodana reported issues

5ccdf9f

fix(gitignore): Removed debug.samt from index

6b776b0

File is now actively ignored

PascalHonegger approved these changes Mar 31, 2023

View reviewed changes

KCreate merged commit 2b2a308 into main Mar 31, 2023

KCreate deleted the ast-dump branch March 31, 2023 10:29

Conversation

KCreate commented Mar 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Todos

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

KCreate commented Mar 31, 2023

Uh oh!

PascalHonegger commented Mar 31, 2023

Uh oh!

KCreate commented Mar 31, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

KCreate commented Mar 26, 2023 •

edited

Loading