Fix: Resolve naming collision and commit message formatting for git-commit skill#26
Merged
Merged
Conversation
Rename the agent skill from 'git-commit' to 'skill-git-commit' to prevent naming collisions with the custom slash command '/git:commit'. This ensures clear command resolution and a more consistent naming pattern for skills within the extension. BREAKING CHANGE: the skill name has been changed from git-commit to skill-git-commit. Any custom integrations or aliases referencing the old name must be updated.
Update the commit standards reference to explicitly forbid the use of double quotes in commit subjects and bodies. This change ensures consistency with established command constraints and prevents shell-related issues like command truncation. Single quotes are recommended as the alternative.
samucodesh
added
bug
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request renames the git-commit skill to skill-git-commit and adds rules to the commit standards prohibiting double quotes in subjects and bodies. Reviewers identified the rename as a breaking change and suggested updating the guidelines for consistency. They also recommended aligning the terminology for the double quote restriction with other configuration files to ensure clarity.
Update version number to 0.3.0 and remove redundant configuration fields from the manifest. By stripping out tools, model, and temperature settings, the extension becomes more lightweight and relies on core defaults, simplifying future updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses the critical issues reported in #25 regarding the git-commit agent skill. It eliminates the naming collision with the
/git:commitslash command by renaming the skill and introduces strict formatting rules to prevent commit message truncation caused by improper quote handling in the shell.Changes Made
git-committoskill-git-commit. This resolves the ambiguity and potentialexecution errors caused by the naming collision with the
/git:commitslash command.subject and body.
messages. This ensures that generated git commit commands are not prematurely truncated by the
shell, leading to cleaner and more reliable commit logs.
Related Issues
Closes #25
Type of Change
Please select the type of change that applies to this PR:
Checklist
Screenshots/Video
If your changes affect the UI/UX, please provide screenshots or a video recording.