Merged
Conversation
Contributor
Author
|
This kinda depends on #2, but I know that one has breaking changes. If we want this to go in first I should change the |
samuelcastro
approved these changes
Aug 16, 2019
Owner
samuelcastro
left a comment
There was a problem hiding this comment.
It looks great, you mentioned breaking changes, do we have any breaking changes here?
Contributor
Author
|
None here 😄 |
Owner
|
Another thing, we need to update the |
Contributor
Author
|
Added docs and renamed the hooks. We might still have a discrepancy with what's returned by default from |
samuelcastro
requested changes
Aug 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
useSplitTreatmentI didn't see a need to include multiple splits because the hook can just be called multiple times, which is inline with what React suggests.
Maybe it would be good to return it as an array/tuple instead that way the individual treatments can be relabeled easier?Changed to that.useSplitTrackMaybe
useTrackwould be better? And if it's ambiguous people can rename on import? I guess same goes for the other hook too.