Skip to content

Fix XLSX formula alignment for offset ranges#1

Closed
hewliyang wants to merge 1 commit into
samuelcolvin:mainfrom
hewliyang:fix-xlsx-range-formula-offset
Closed

Fix XLSX formula alignment for offset ranges#1
hewliyang wants to merge 1 commit into
samuelcolvin:mainfrom
hewliyang:fix-xlsx-range-formula-offset

Conversation

@hewliyang
Copy link
Copy Markdown

Summary

  • account for non-zero calamine range starts when pairing XLSX cells with formulas and metadata
  • use the explicit uncached-formula flag when deciding whether to invoke formula backfill
  • add a regression test for a worksheet whose populated range starts below A1

Testing

  • DEVELOPER_DIR=/Applications/Xcode.app/Contents/Developer cargo test --locked

This fixes cases where cached formula values were incorrectly treated as missing, causing unnecessary and very slow formula graph construction on workbooks with offset ranges.

@hewliyang hewliyang closed this May 21, 2026
@hewliyang hewliyang deleted the fix-xlsx-range-formula-offset branch May 21, 2026 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant