Conversation
Owner
samupl
commented
Mar 25, 2026
- Fix: Nazwa element placement — Moved buyer name (Nazwa) inside DaneIdentyfikacyjne where the FA(3) schema requires it, instead of directly under Podmiot2
- Fix: XML element ordering — Moved Adres before Nazwa in Podmiot2, and P_13/P_14 tax summary before P_15 in Fa
- Add: Invoice row fields — InvoiceRow now supports unit_of_measure (P_8A), quantity (P_8B), unit_net_price (P_9A), net_value (P_11), and delivery_date (P_6A)
- Add: Tax rate type safety — Replaced int tax field with TaxRate literal type covering all 14 valid TStawkaPodatku enum values. Added constants (TAX_23, TAX_0_WDT, TAX_NP_I, etc.)
- Add: OSS/IOSS support — InvoiceRow.tax_oss field (P_12_XII) for EU consumer VAT rates not in the standard enum (e.g. 21%, 19%)
- Add: Tax summary — TaxSummary model with all P_13_/P_14_ fields for net/VAT totals per rate group, added as optional field on InvoiceData
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.