Allow for only thumbnail url in csv #968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShanaLMoore
previously approved these changes
Aug 19, 2024
ShanaLMoore
reviewed
Aug 19, 2024
|
|
||
| def combined_files_with(remote_files:) | ||
| thumbnail_url = self.attributes['thumbnail_url'] | ||
| return [thumbnail_url] if remote_files.blank? |
Contributor
There was a problem hiding this comment.
@laritakr to clarify, if thumbnail_url is also blank it'll return an empty array and avoid the error?
Contributor
Author
There was a problem hiding this comment.
An empty array should avoid the error (the error was trying to merge the thumbnail url into a nil remote_files value.)
But would be a good thing to double-check.
ShanaLMoore
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles situation where the csv has a thumbnail_url but no related_url to use as remote files.
Previously threw an error:
NoMethodError - undefined method + for nil:NilClass