Reimbursement: sync as QBO Bill#111
Merged
Merged
Conversation
Reimbursements were the one payable host that didn't sync to QuickBooks —
they sat in Stacks balance forever and were historically settled via a
matching negative ContributorAdjustment booked off-platform. This makes
reimbursements follow the same lifecycle as ContributorPayout, Trueup,
ProfitShare, ContributorAdjustment, and PayStub:
• New qbo_bill_id column on reimbursements
• include SyncsAsQboBill
• bill_txn_date / bill_description / bill_doc_number_code ("RB")
Toggle-acceptance hook now:
• Accept → r.sync_qbo_bill! (best-effort; logs on Deel/QBO failure)
• Deny → r.detach_and_destroy_qbo_bill
For existing accepted reimbursements:
bundle exec rake reimbursements:backfill_qbo_bills
The rake task is idempotent — it only pushes rows with qbo_bill_id NULL,
and silently skips contributors without a ContributorQboVendor mapping.
QBO account routing uses the default "Contractors - Client Services";
override Reimbursement#find_qbo_account! if a different expense category
is wanted (e.g., Reimbursable Expenses).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes `Reimbursement` follow the same QBO Bill lifecycle as every other payable host (ContributorPayout, ContributorAdjustment, ProfitShare, Trueup, PayStub). Previously reimbursements never pushed to QBO and were settled by hand via a matching negative ContributorAdjustment booked off-platform — that made them invisible to the QBO vendor record.
Changes
QBO account routing
Uses the default "Contractors - Client Services" category (same as other hosts). If a different expense category is wanted later, override `Reimbursement#find_qbo_account!`.
Rollout
Test plan
🤖 Generated with Claude Code