Extract common utility functions #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marekrozmus
approved these changes
Oct 4, 2019
|
@all-contributors please add sandstreamdevelopment for business, financial, ideas |
Contributor
|
I've put up a pull request to add @sandstreamdevelopment! 🎉 |
…eamdevelopment docs: add sandstreamdevelopment as a contributor
jakubbogacz
approved these changes
Oct 8, 2019
| @@ -0,0 +1,2 @@ | |||
| export default xs => | |||
| xs.filter((value, index, self) => self.indexOf(value) !== index); | |||
Member
There was a problem hiding this comment.
Ok, good to know the idea, which you had behind that function - definitely we are missing docs. So.. maybe we should add unique helper?
jakubbogacz
approved these changes
Oct 8, 2019
|
@all-contributors please add przemyslawzalewski for code, ideas |
Contributor
|
I've put up a pull request to add @przemyslawzalewski! 🎉 |
|
@all-contributors please add jakubbogacz for ideas, review |
Contributor
|
I've put up a pull request to add @jakubbogacz! 🎉 |
|
@all-contributors please add marekrozmus for review |
Contributor
|
I've put up a pull request to add @marekrozmus! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR comes with a bunch of small utility functions extracted from our various projects. As the public API is not yet defined, this is more like a proof of concept to see if we can replace at least some of the duplicated helpers.