-
Notifications
You must be signed in to change notification settings - Fork 0
Add zipN method #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add zipN method #38
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| export default (...xs) => { | ||
| const [head = [], ...tail] = xs; | ||
|
|
||
| return head.map((value, index) => | ||
| tail.reduce((x, xs) => [...x, xs[index]], [value]) | ||
| ); | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| { | ||
| "name": "zipN", | ||
| "description": "Zips given arrays", | ||
| "signature": "(...xs: any[][]) => any[][]", | ||
| "examples": [ | ||
| { | ||
| "language": "javascript", | ||
| "content": "zipN([1, 2, 3], [4, 5, 6]); // ⇒ [[1, 4], [2, 5], [3, 6]]" | ||
| }, | ||
| { | ||
| "language": "javascript", | ||
| "content": "zipN([1, 2, 3], [4, 5, 6], [7, 8, 9]); // ⇒ [[1, 4, 7], [2, 5, 8], [3, 6, 9]]" | ||
| }, | ||
| { | ||
| "language": "javascript", | ||
| "content": "zipN([1, 2], [4, 5, 6], [7, 8, 9]); // ⇒ [[1, 4, 7],[2, 5, 8]]" | ||
| } | ||
| ], | ||
| "questions": ["TODO: List questions that may this function answers."] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| # zipN | ||
|
|
||
| Zips given arrays | ||
|
|
||
| ## Type signature | ||
|
|
||
| <!-- prettier-ignore-start --> | ||
| ```typescript | ||
| (...xs: any[][]) => any[][] | ||
| ``` | ||
| <!-- prettier-ignore-end --> | ||
|
|
||
| ## Examples | ||
|
|
||
| <!-- prettier-ignore-start --> | ||
| ```javascript | ||
| zipN([1, 2, 3], [4, 5, 6]); // ⇒ [[1, 4], [2, 5], [3, 6]] | ||
| ``` | ||
|
|
||
| ```javascript | ||
| zipN([1, 2, 3], [4, 5, 6], [7, 8, 9]); // ⇒ [[1, 4, 7], [2, 5, 8], [3, 6, 9]] | ||
| ``` | ||
|
|
||
| ```javascript | ||
| zipN([1, 2], [4, 5, 6], [7, 8, 9]); // ⇒ [[1, 4, 7],[2, 5, 8]] | ||
| ``` | ||
| <!-- prettier-ignore-end --> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| /* eslint-env jest */ | ||
| // @ts-ignore ambiguous import | ||
| import zipN from "./zipN.ts"; | ||
|
|
||
| describe("zip", () => { | ||
| it("should zip with pair constructor", () => { | ||
| expect(zipN([1, 2, 3], [4, 5, 6])).toEqual([ | ||
| [1, 4], | ||
| [2, 5], | ||
| [3, 6] | ||
| ]); | ||
| }); | ||
|
|
||
| it("should zip up to the left arrays length", () => { | ||
| expect(zipN([1, 2, 3, 4, 5, 7], [4, 5, 6])).toEqual([ | ||
| [1, 4], | ||
| [2, 5], | ||
| [3, 6], | ||
| [4, undefined], | ||
| [5, undefined], | ||
| [7, undefined] | ||
| ]); | ||
|
|
||
| expect(zipN([1, 2, 3], [4, 5, 6, 4, 5, 7])).toEqual([ | ||
| [1, 4], | ||
| [2, 5], | ||
| [3, 6] | ||
| ]); | ||
| }); | ||
|
|
||
| it("should return the wrapped elements of the source array when only one array is given", () => { | ||
| expect(zipN([1, 2])).toEqual([[1], [2]]); | ||
| }); | ||
|
|
||
| it("should return an empty array when the given array is empty", () => { | ||
| expect(zipN([])).toEqual([]); | ||
| }); | ||
|
|
||
| it("should return an empty array when the given nothing", () => { | ||
| expect(zipN()).toEqual([]); | ||
| }); | ||
|
|
||
| it("should zip three arrays with the same lengths", () => { | ||
| expect(zipN([1, 2, 3], [4, 5, 6], [7, 8, 9])).toEqual([ | ||
| [1, 4, 7], | ||
| [2, 5, 8], | ||
| [3, 6, 9] | ||
| ]); | ||
| }); | ||
|
|
||
| it("should zip three arrays with different lengths", () => { | ||
| expect(zipN([1, 2, 3], [4, 5, 6], [7, 8])).toEqual([ | ||
| [1, 4, 7], | ||
| [2, 5, 8], | ||
| [3, 6, undefined] | ||
| ]); | ||
|
|
||
| expect(zipN([1, 2, 3], [4, 5], [7, 8, 9])).toEqual([ | ||
| [1, 4, 7], | ||
| [2, 5, 8], | ||
| [3, undefined, 9] | ||
| ]); | ||
|
|
||
| expect(zipN([1, 2], [4, 5, 6], [7, 8, 9])).toEqual([ | ||
| [1, 4, 7], | ||
| [2, 5, 8] | ||
| ]); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| export default (...xs: any[][]) => { | ||
| const [head = [], ...tail] = xs; | ||
|
|
||
| return head.map((value, index) => | ||
| tail.reduce((x, xs) => [...x, xs[index]], [value]) | ||
| ); | ||
| }; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will fail for the case
zipN()- please guard against it and cover it with tests.