Skip to content

fix: return a value from object find, not an entry #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
przemyslawzalewski merged 1 commit into from
Oct 8, 2019
Merged

fix: return a value from object find, not an entry #6

przemyslawzalewski merged 1 commit into from
Oct 8, 2019
+6 −2

Conversation

@przemyslawzalewski
Copy link
Member

@przemyslawzalewski przemyslawzalewski commented Oct 8, 2019

This matches behavior of Array.prototype.find()
 as it returns a value, not a [value, index] pair.

@przemyslawzalewski przemyslawzalewski merged commit 6966ef9 into master Oct 8, 2019
@jakubbogacz jakubbogacz deleted the fix_object_find branch October 9, 2019 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakubbogacz jakubbogacz jakubbogacz approved these changes

+1 more reviewer

@marekrozmus marekrozmus marekrozmus approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@przemyslawzalewski @jakubbogacz @marekrozmus