Query string requests don't seem to be matched

[jertje260]

Requests with querystrings don't seem to be matched properly.

Created a repro test case, which fails:

        [Fact]
        public void GivenRouteWithParameterAndQueryStringUsingTheBuilder_RequestBuilderIsReturned()
        {
            var requestBuilder = (RequestBuilder)new RequestBuilder().Get().ForUrl("/api/foos/{id}").WithQueryStringParameter("blah").HavingAnyValue();

            var routes = new List<RequestBuilder>
            {
                requestBuilder,
            };

            var dictionary = ConfiguredRequests.FromRequestBuilders(routes);

            dictionary
                .Match(
                    HttpMethod.Get,
                    "/api/foos/1234?blah=baz",
                    null)
                .Should()
                .Be(requestBuilder);
        }

I don't have a fix for this yet, but working on it.

Looks like it fails in the matching, because the query string like this is not added to the _queryParameters in the RequestQueryNode. Therefore the count matching fails, therefore doesn't return it.

When using the old api for the builder, it does work, so using:

_testableMessageHandler.RespondTo(HttpMethod.Get, "/api/foos/{id}").WithQueryStringParameter("blah").HavingAnyValue()

[bdukes]

Looking at other tests, it appears that the query string needs to be part of the ForUrl argument in order to be matched.

@sandermvanvliet is this intentional behavior, or would you expect that you should be able to specify a URL without a query string parameter, and then use WithQueryStringParameter to indicate that there should be that parameter? Like the OP, we were also getting stuck on this until I started trying to create a test case using your existing test suite and noticed the query string in the example data.

Also, FWIW, the OP indicates that the old API works for them, while that did not make a difference for us.