Skip to content

Fix bugs in lock diff #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Fix bugs in lock diff #616

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d50d6d
Fix bugs in lock diff
psakievich Sep 10, 2024
315f54f
Merge branch 'main' into b/lock-diff-bugs
psakievich Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion manager/manager_cmds/lock_diff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ def setup_parser_args(subparser):
"--skip-package-diffs",
"-s",
nargs="+",
default=[],
help="packages to skip package hash diffs",
required=False,
)
Expand Down Expand Up @@ -104,7 +105,7 @@ def old_vs_new(old_dict, new_dict):
diff_msg += "package hash change - Old: {} New: {}".format(
old_spec.package_hash(), new_spec.package_hash()
)
if new_spec.name not in args.skip_package_diffs:
if spec.name not in args.skip_package_diffs:
unacceptable_changes = True
else:
# something else must have changed in concretization that
Expand Down
Loading