Skip to content

Conversation

@jmgate
Copy link
Collaborator

@jmgate jmgate commented Jan 21, 2025

Type: Documentation

Description

Using this alias means we're no longer overshadowing the copyright built-in, so we can remove the comment to ignore that Ruff linting rule.

Summary by Sourcery

Use the project_copyright alias instead of the built-in copyright to avoid overshadowing it.

Enhancements:

  • Removed the Ruff linting rule that ignored the copyright built-in.

Documentation:

  • Replaced the usage of the built-in copyright with the project_copyright alias.

Using this alias means we're no longer overshadowing the `copyright`
built-in, so we can remove the comment to ignore that Ruff linting rule.
@jmgate jmgate self-assigned this Jan 21, 2025
@sourcery-ai
Copy link

sourcery-ai bot commented Jan 21, 2025

Reviewer's Guide by Sourcery

This pull request renames the copyright variable to project_copyright in the conf.py file to avoid shadowing the built-in copyright keyword.

Class diagram showing configuration variable change

classDiagram
    class SphinxConfig {
        +String project
        +String project_copyright
        +String author
        note for SphinxConfig "Renamed 'copyright' to 'project_copyright'
to avoid shadowing built-in"
    }
Loading

File-Level Changes

Change Details Files
Renamed the copyright variable to project_copyright.
  • Renamed the copyright variable to project_copyright.
  • Removed the noqa: A001 comment.
doc/source/conf.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jmgate - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5dcb3bf) to head (43f1d31).
Report is 46 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #169   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          180       180           
  Branches        15        15           
=========================================
  Hits           180       180           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jmgate
Copy link
Collaborator Author

jmgate commented Jan 21, 2025

@william76, @GhostofGoes, @jcox10, anyone care to review and approve?

@GhostofGoes
Copy link
Collaborator

Is this variable referenced anywhere?

@GhostofGoes
Copy link
Collaborator

Oh this is in conf.py derp

@jmgate jmgate merged commit 230bf4e into master Jan 21, 2025
14 checks passed
@jmgate jmgate deleted the project-copyright branch January 21, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants