-
Notifications
You must be signed in to change notification settings - Fork 1
docs: Switch to project_copyright
#169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Using this alias means we're no longer overshadowing the `copyright` built-in, so we can remove the comment to ignore that Ruff linting rule.
Reviewer's Guide by SourceryThis pull request renames the Class diagram showing configuration variable changeclassDiagram
class SphinxConfig {
+String project
+String project_copyright
+String author
note for SphinxConfig "Renamed 'copyright' to 'project_copyright'
to avoid shadowing built-in"
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jmgate - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #169 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 180 180
Branches 15 15
=========================================
Hits 180 180 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@william76, @GhostofGoes, @jcox10, anyone care to review and approve? |
|
Is this variable referenced anywhere? |
|
Oh this is in conf.py derp |
Type: Documentation
Description
Using this alias means we're no longer overshadowing the
copyrightbuilt-in, so we can remove the comment to ignore that Ruff linting rule.Summary by Sourcery
Use the
project_copyrightalias instead of the built-incopyrightto avoid overshadowing it.Enhancements:
copyrightbuilt-in.Documentation:
copyrightwith theproject_copyrightalias.