Skip to content

Neos 9 Compatibility#32

Merged
JamesAlias merged 12 commits intomasterfrom
neos9
May 21, 2025
Merged

Neos 9 Compatibility#32
JamesAlias merged 12 commits intomasterfrom
neos9

Conversation

@JamesAlias
Copy link
Contributor

@JamesAlias JamesAlias commented Apr 30, 2025

Follow up of #31

** THIS WILL BE A BREAKING CHANGE! ** -> and will be released as v4.

I am not sure about using inline styles for alignment, but it works.

There are 2 TODOs that can be removed, but I feel like the PropertyValuesToWrite ValueObject would be easier to handle if it would provide the two functions:

function hasProperty(PropertyName $propertyName): bool
function getProperty(PropertyName $propertyName): mixed

@JamesAlias JamesAlias requested a review from skurfuerst April 30, 2025 12:38
@JamesAlias JamesAlias self-assigned this Apr 30, 2025
@JamesAlias
Copy link
Contributor Author

One issue I found is that the LOCAL version does not provide the img assets for content like clipart. They are expected at for instance /neos/mxgraph/img/lib/clip_art/finance/Credit_Card_128x128.png

With drawioEmbedUrl: https://embed.diagrams.net it works and the images are inlined in the svg via base64.

So maybe we need to update the drawio assets for local embed.

@JamesAlias JamesAlias merged commit d4e75c3 into master May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants