Merged
Conversation
- NOT tested so far
Useing esbuild and remove plowjs
Contributor
Author
|
One issue I found is that the LOCAL version does not provide the img assets for content like With So maybe we need to update the drawio assets for local embed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up of #31
** THIS WILL BE A BREAKING CHANGE! ** -> and will be released as v4.
I am not sure about using inline styles for alignment, but it works.
There are 2 TODOs that can be removed, but I feel like the
PropertyValuesToWriteValueObject would be easier to handle if it would provide the two functions:function hasProperty(PropertyName $propertyName): boolfunction getProperty(PropertyName $propertyName): mixed