Change logo to have transparent background#29
Merged
on3iro merged 1 commit intosandstorm:mainfrom Nov 27, 2021
Merged
Conversation
On any background that isn't white it's quite jarring to have a white cutout around the logo. Making the logo background transparent solves this issue, although the logo might now be less distinct if the page it's displayed on matches the logo colours.
Contributor
|
Hi @WalterSmuts thanks for the contribution. Yeah I actually also have an svg without background of the logo, however I was unsure if it was better that way on dark backgrounds. You are probably right, though and we should use the version without background for now. Thanks again for the contribution :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On any background that isn't white it's quite jarring to have a white
cutout around the logo. Making the logo background transparent solves
this issue, although the logo might now be less distinct if the page
it's displayed on matches the logo colours.
Before:
After:
