#215 Add NumberStyles MappaSettings for string-to-numeric parsing#226
Merged
sanelli merged 4 commits intoJun 21, 2026
Merged
Conversation
… 1). Add UndefinedNumberStyle sentinel and eleven NumberStyles properties on MappaSettingsAttribute. Bump Mappa to 10.1.0-alpha.6 for downstream generator work. Co-authored-by: Cursor <cursoragent@cursor.com>
…(steps 2-3). Add ParseNumberStylesCodeHelper, per-type style settings in the generator stack, and NumberStyles-aware Parse overload emission for string-to-numeric mapping. Add 99 integration tests covering method/class/editorconfig, override hierarchy, regression, and combined culture. Co-authored-by: Cursor <cursoragent@cursor.com>
…teps 4-7). Bump Mappa to 10.1.0-alpha.7 after generator changes. Add method- and class-level NumberStyles samples with runtime and AOT coverage. Co-authored-by: Cursor <cursoragent@cursor.com>
… (step 8). Document per-type NumberStyles settings, editorconfig keys, and generator parse overload selection for string-to-numeric mapping. Co-authored-by: Cursor <cursoragent@cursor.com>
sanelli
deleted the
215-support-numberstyles-for-parse-for-all-numeric-types
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NumberStylesproperties toMappaSettings(ByteStylethroughDoubleStyle) for controlling string-to-numericParseoverload selection, mirroring theDateTimeStylepattern from SupportDateTimeStyleforParseandParseExactforDateTime,DateOnly,TimeOnly#214..editorconfig, and global options) viaParseNumberStylesCodeHelper, selectingParse(input),Parse(input, style), orParse(input, style, culture)as appropriate.10.1.0-alpha.7.Test plan
.\Scripts\RunTestsAndReportCoverage.ps1— 1870 tests passed(1,234)/(1,234.50)parsing withAllowThousands | AllowParenthesesMade with Cursor