#229 Fix .editorconfig CurrentCulture mapping in MappaGlobalOptions#235
Merged
sanelli merged 1 commit intoJun 21, 2026
Merged
Conversation
Correct GetCultureInfoSettingsFromString to return CurrentCulture instead of None, add an editorconfig integration test for string-to-number parsing, and bump the generator version to alpha.10. Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
sanelli
deleted the
229-fix-editorconfig-currentculture-mapping-in-mappaglobaloptions
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetCultureInfoSettingsFromStringsomappa.cultureinfosettings = CurrentCulturein.editorconfigresolves toCultureInfoSetting.CurrentCultureinstead ofNone.CanMapStringToNumberWithCurrentCultureDefinedInEditorConfigcovering editorconfig-only current culture for string-to-number parsing.10.1.0-alpha.10.Test plan
CanMapStringToNumberWithCurrentCultureDefinedInEditorConfigpasses (11 theory cases).\Scripts\RunTestsAndReportCoverage.ps1Closes #229
Made with Cursor