Skip to content

Y25-318 Publish gem as sanger-jsonapi-resources#3

Merged
seenanair merged 11 commits into
developfrom
y25-318-from-develop
Jun 17, 2025
Merged

Y25-318 Publish gem as sanger-jsonapi-resources#3
seenanair merged 11 commits into
developfrom
y25-318-from-develop

Conversation

@seenanair
Copy link
Copy Markdown

@seenanair seenanair commented Jun 12, 2025

Closes sanger/General-Backlog-Items#569

All Submissions:

This pull request updates the gem to sanger-jsonapi-resources from the develop branch of forked jsonapi-resources repository, including adjustments to the gem name, version, and packaging to ensure compatibility with RubyGems and Bundler. The most important changes are grouped below:

Gem Name and Metadata Updates:

  • Updated the gem name from jsonapi-resources to sanger-jsonapi-resources in the Gemfile installation instructions within README.md and in the jsonapi-resources.gemspec file.
  • Modified the gem description in jsonapi-resources.gemspec to indicate that it is a fork of the original jsonapi-resources gem.

ActiveRecord Fixture Updates:

Updated table definitions to support Rails version >7.0

Test Suite Adjustments:

Established the database connection before loading schemas, updated fixture paths, and removed unused Rails test helpers for streamlined testing.

All Submissions:

This pull request updates the gem to sanger-jsonapi-resources from the develop branch of forked jsonapi-resources repository, including adjustments to the gem name, version, and packaging to ensure compatibility with RubyGems and Bundler. The most important changes are grouped below:

Version Update:

  • Changed the gem version from 0.9.0 to 0.1.1 in lib/jsonapi/resources/version.rb to reflect the fork's new versioning.
    Version 0.1.1, as 0.1.0 has already been published with some issues. Those issues have been fixed in this version, and the version number has been bumped accordingly.

@seenanair
Copy link
Copy Markdown
Author

@stevieing ,@BenTopping - Just to let you know, this hasn’t been published yet. Once it’s approved, I’ll merge it into develop and then publish it as a gem.

Copy link
Copy Markdown

@stevieing stevieing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you manage to get the tests running locally?

@seenanair
Copy link
Copy Markdown
Author

Did you manage to get the tests running locally?

SS RSpec tests always have some failures when I run them locally, and the same happened with this branch (as with develop). Similarly, I’ve never been able to run the Cucumber tests locally, so I always rely on CI.

@stevieing
Copy link
Copy Markdown

stevieing commented Jun 12, 2025

Did you manage to get the tests running locally?

SS RSpec tests always have some failures when I run them locally, and the same happened with this branch (as with develop). Similarly, I’ve never been able to run the Cucumber tests locally, so I always rely on CI.

Oh, I didn't. I will give it a go.

…7.1.0 which are required for compatibility with Rails 7.1 and Ruby 3.x
…and < 3.0 (ensuring compatibility with both older and newer Ruby/Rails setups, while avoiding breaking changes introduced in Bundler 3.x.) ; add runtime dependency for csv (because Ruby 3.4+ no longer includes the csv library by default)
…recent Rails versions, replacing deprecated or invalid patterns to ensure proper table and index creation.
Comment thread jsonapi-resources.gemspec Outdated
Comment thread .github/workflows/ruby.yml
@seenanair
Copy link
Copy Markdown
Author

seenanair commented Jun 17, 2025

@stevieing , @BenTopping - Following are the updates

  • All tests are now passing.
  • I’ve also created a Sequencescape PR that uses the sanger-jsonapi-resources gem, pulled by pointing to this branch of jsonapi-resources which passed all tests as well.

The next step, once this is approved, is to release it as a gem and then update Sequencescape to use the published gem and test against it.

Copy link
Copy Markdown

@stevieing stevieing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work :)

@seenanair seenanair merged commit c4c17a4 into develop Jun 17, 2025
4 checks passed
@stevieing stevieing requested a review from harrietc52 June 17, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants