Y25-318 Publish gem as sanger-jsonapi-resources#3
Conversation
… update description for clarity
…i-resources gem to ensure compatibility with RubyGems and Bundler
|
@stevieing ,@BenTopping - Just to let you know, this hasn’t been published yet. Once it’s approved, I’ll merge it into develop and then publish it as a gem. |
stevieing
left a comment
There was a problem hiding this comment.
Did you manage to get the tests running locally?
SS RSpec tests always have some failures when I run them locally, and the same happened with this branch (as with develop). Similarly, I’ve never been able to run the Cucumber tests locally, so I always rely on CI. |
Oh, I didn't. I will give it a go. |
…7.1.0 which are required for compatibility with Rails 7.1 and Ruby 3.x
…and < 3.0 (ensuring compatibility with both older and newer Ruby/Rails setups, while avoiding breaking changes introduced in Bundler 3.x.) ; add runtime dependency for csv (because Ruby 3.4+ no longer includes the csv library by default)
…n controller and resource generators
…recent Rails versions, replacing deprecated or invalid patterns to ensure proper table and index creation.
… with Ruby and Rails testing
|
@stevieing , @BenTopping - Following are the updates
The next step, once this is approved, is to release it as a gem and then update Sequencescape to use the published gem and test against it. |
…ownership and repository link
Closes sanger/General-Backlog-Items#569
All Submissions:
This pull request updates the gem to
sanger-jsonapi-resourcesfrom the develop branch of forked jsonapi-resources repository, including adjustments to the gem name, version, and packaging to ensure compatibility with RubyGems and Bundler. The most important changes are grouped below:Gem Name and Metadata Updates:
jsonapi-resourcestosanger-jsonapi-resourcesin theGemfileinstallation instructions withinREADME.mdand in thejsonapi-resources.gemspecfile.jsonapi-resources.gemspecto indicate that it is a fork of the originaljsonapi-resourcesgem.ActiveRecord Fixture Updates:
Updated table definitions to support Rails version >7.0
Test Suite Adjustments:
Established the database connection before loading schemas, updated fixture paths, and removed unused Rails test helpers for streamlined testing.
All Submissions:
This pull request updates the gem to
sanger-jsonapi-resourcesfrom the develop branch of forked jsonapi-resources repository, including adjustments to the gem name, version, and packaging to ensure compatibility with RubyGems and Bundler. The most important changes are grouped below:Version Update:
0.9.0to0.1.1inlib/jsonapi/resources/version.rbto reflect the fork's new versioning.Version 0.1.1, as 0.1.0 has already been published with some issues. Those issues have been fixed in this version, and the version number has been bumped accordingly.