Skip to content

Develop to master#392

Merged
emrojo merged 194 commits intomasterfrom
develop
Jul 14, 2021
Merged

Develop to master#392
emrojo merged 194 commits intomasterfrom
develop

Conversation

@emrojo
Copy link
Copy Markdown
Contributor

@emrojo emrojo commented Jul 14, 2021

Closes #

Changes proposed in this pull request:

  • ...

pjvv and others added 30 commits June 2, 2021 14:36
pjvv and others added 27 commits July 7, 2021 16:10
Plumbing between Lighthouse and Cherrytrack
This should be a system ignore setting, not repeated in every repo
Classes that start Test will be auto-collected and we don't need this to be
Housekeeping/Create and fail destination plates
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 14, 2021

Codecov Report

Merging #392 (c5551bc) into master (9ad71b0) will increase coverage by 2.10%.
The diff coverage is 93.80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #392      +/-   ##
==========================================
+ Coverage   90.04%   92.15%   +2.10%     
==========================================
  Files          38       91      +53     
  Lines        1417     2994    +1577     
  Branches      133      240     +107     
==========================================
+ Hits         1276     2759    +1483     
- Misses        119      192      +73     
- Partials       22       43      +21     
Impacted Files Coverage Δ
lighthouse/config/development.py 0.00% <0.00%> (ø)
lighthouse/validator.py 66.66% <66.66%> (ø)
lighthouse/types.py 75.00% <70.83%> (-25.00%) ⬇️
lighthouse/classes/events/plate_event_interface.py 72.72% <72.72%> (ø)
lighthouse/classes/automation_system.py 75.86% <75.86%> (ø)
..._properties/interfaces/event_property_interface.py 77.27% <77.27%> (ø)
...hthouse/classes/messages/sequencescape_messages.py 77.41% <77.41%> (ø)
lighthouse/messages/broker.py 88.88% <83.33%> (-7.89%) ⬇️
lighthouse/classes/services/labwhere.py 85.71% <85.71%> (ø)
...ties/definitions/source_plates_from_destination.py 88.09% <88.09%> (ø)
... and 118 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ad71b0...c5551bc. Read the comment docs.

@emrojo emrojo merged commit 1d9ef9c into master Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants