Skip to content

Develop to master#410

Merged
emrojo merged 101 commits intomasterfrom
develop
Aug 3, 2021
Merged

Develop to master#410
emrojo merged 101 commits intomasterfrom
develop

Conversation

@emrojo
Copy link
Copy Markdown
Contributor

@emrojo emrojo commented Aug 3, 2021

Closes DPL-058, DPL-056, DPL-080,

Changes proposed in this pull request:

  • DPL-058 Add endpoint versioning [Heron]
  • DPL-056 [misunderstanding] Priority Samples Change (for Biosero) - Source plates lookup endpoint [Heron]
  • DPL-080 Check plate existence in Sequencescape
  • GPL-967 UAT Action - Setup Cherrypick Test Data Endpoints [Heron]
  • GPL-969 UAT Action - Setup Cherrypick Test Data UI [Heron]

sdjmchattie added 30 commits July 12, 2021 14:42
@sdjmchattie
Update release version
d4d6fd0
@sdjmchattie
Add a config for whether to include cherrypicker endpoints
71ef6fa
@sdjmchattie
Add kwargs to all endpoints in responses
aaed5c6
@sdjmchattie
Add new POST endpoint for creating cherrypicker test data
4006103
@sdjmchattie
Implement checking of endpoint types and create stub responses
0ff5055
@sdjmchattie
Fix linting issues
e6fcf13
@sdjmchattie
Add tests for request json body helper
18cc721
@sdjmchattie
Fix linting issues in test
2ef9a82
@sdjmchattie
Remove empty validators module
8b865f4
@sdjmchattie
Use Eve to create endpoints for cherrypicker test data
e3bd269
@sdjmchattie
Add hooks for handling inserts of cherrypicker test data
e08d829
@sdjmchattie
Add validation for the plate_specs value
d783ed5
@sdjmchattie
Set the endpoint URL to use dashes instead of underscores
30c4383
@sdjmchattie
Fix naming of hook methods
b3cf8f7
@sdjmchattie
Test the cherrypick endpoint validator
1b9d58d
@sdjmchattie
Remove unused requests helper methods
e5c7b7f
@sdjmchattie
Test that the Eve domain config is correctly specified and working
0f12abd
@sdjmchattie
Add test for creating and checking what was created
21be928
@sdjmchattie
Fix linting
4fcbb60
@sdjmchattie
Disable submitting multiple runs at once
8de383f
@sdjmchattie
Remove unneeded constants
e645a46
@sdjmchattie
Remove unnecessary separate strings
23ed457
@sdjmchattie
Add call to Crawler on creating cherrypicker data
c9d6115
@sdjmchattie
Raise for status on the crawler response
f5c5d65
@sdjmchattie
Merge branch 'develop' into GPL-967-cherrypicker-generate-stub
ed4863e 
# Conflicts:
#	.release_version
#	lighthouse/config/defaults.py
@sdjmchattie
Increment the release version -> 2.13.0
a06cd02
@sdjmchattie
Add tests for valid inputs
367a648
@sdjmchattie
Move mutable default value inside method
ff8b1b8
@sdjmchattie
Fix tests to give a proper response mock
068089c
@sdjmchattie
Move database dependencies to a separate docker compose file
7543c32
sdjmchattie and others added 28 commits July 22, 2021 15:37
@sdjmchattie
Move plates endpoints to new v1 routes.py file
d500011
@sdjmchattie
Add reports endpoints to v1 routes.py
98e4202
@sdjmchattie
Move beckman endpoints to v1 routes.py
644ac2d
@sdjmchattie
Add cherrypicked plates endpoints to v1 routes
cc80c7c
@sdjmchattie
Reinstate QA override
7668acd
@andrewsparkes
Updated readme to mention dependencies when running docker tests
cfab278
@andrewsparkes
Changed query for selecting pickable samples to not pick preferential…
9ac22e6 
…ly sequenced ones if not fit to pick
@sdjmchattie
Move plate-events endpoint to v1 routes
1ad422e
@sdjmchattie
Update tests for beckman robots and failure types
de94df4
@sdjmchattie
Merge prefixes on to endpoints before parametrizing tests
f7b46c4
@sdjmchattie
Update tests for cherrypicked plates
c31359c
@sdjmchattie
Update tests for plate events endpoints
1b5ae55
@sdjmchattie
Update plates endpoint tests
1f2a1b6
@andrewsparkes
Added a test sample that is preferential sequence true but not fit to…
0c5c17e 
… pick
@sdjmchattie
Update tests for reports
97f9e5c
@andrewsparkes
Upped version number
fe56603
@sdjmchattie
Specify type of except when getting httperror message
70bdd7b
@sdjmchattie
Update release version -> 2.17.0
07ea7dd
@sdjmchattie
Merge branch 'develop' into DPL-058-versioned-endpoints
fadb0a9
@andrewsparkes
linted
3a8b8c5
@emrojo
Merge pull request #404 from sanger/dpl056-priority-samples-lims-lookup
fcc8a3e 
Dpl056 priority samples lims lookup
@sdjmchattie
Handle exception for missing key instead of checking
59d1016
@sdjmchattie
Add more information about how the eve_routes.py work
1446577
@sdjmchattie
Increment release version -> 2.18.0
9d39a52
@sdjmchattie
Remove _v1 suffix on common method names
1fd0665
@sdjmchattie
Add unique name to root route blueprints
d748630
@sdjmchattie
Merge branch 'develop' into DPL-058-versioned-endpoints
c61dd2d
@sdjmchattie
Merge pull request #405 from sanger/DPL-058-versioned-endpoints
a36aa55 
DPL-058: Versioned endpoints
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 3, 2021

Codecov Report

Merging #410 (a36aa55) into master (1d9ef9c) will increase coverage by 0.13%.
The diff coverage is 97.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #410      +/-   ##
==========================================
+ Coverage   92.15%   92.28%   +0.13%     
==========================================
  Files          91       96       +5     
  Lines        2994     3124     +130     
  Branches      240      248       +8     
==========================================
+ Hits         2759     2883     +124     
- Misses        192      198       +6     
  Partials       43       43
Impacted Files Coverage Δ
lighthouse/config/development.py 0.00% <0.00%> (ø)
lighthouse/constants/aggregation_stages.py 100.00% <ø> (ø)
lighthouse/routes/common/beckman.py 100.00% <ø> (ø)
lighthouse/routes/common/cherrypicked_plates.py 92.63% <ø> (ø)
lighthouse/routes/eve_routes.py 85.18% <85.18%> (ø)
lighthouse/__init__.py 84.84% <92.85%> (+3.36%) ⬆️
lighthouse/helpers/plates.py 93.75% <92.85%> (-0.26%) ⬇️
lighthouse/config/defaults.py 100.00% <100.00%> (ø)
lighthouse/config/schemas.py 100.00% <100.00%> (ø)
lighthouse/config/test.py 100.00% <100.00%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d9ef9c...a36aa55. Read the comment docs.

@emrojo emrojo merged commit e3979f4 into master Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@emrojo @sdjmchattie @pjvv @andrewsparkes