Skip to content

readme improvement#479

Merged
KatyTaylor merged 2 commits intodevelopfrom
readme-improvement
Dec 13, 2021
Merged

readme improvement#479
KatyTaylor merged 2 commits intodevelopfrom
readme-improvement

Conversation

@KatyTaylor
Copy link
Copy Markdown
Contributor

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 13, 2021

Codecov Report

Merging #479 (8019aa6) into develop (0ed9c86) will not change coverage.
The diff coverage is n/a.

❗ Current head 8019aa6 differs from pull request most recent head 209e419. Consider uploading reports for the commit 209e419 to get more accurate results
Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #479   +/-   ##
========================================
  Coverage    92.33%   92.33%           
========================================
  Files           98       98           
  Lines         3248     3248           
  Branches       330      330           
========================================
  Hits          2999     2999           
  Misses         203      203           
  Partials        46       46           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ed9c86...209e419. Read the comment docs.

Comment thread README.md Outdated
docker-compose up

This will keep running continuously in your console window, so to execute further commands you'll need
to open a new console window or tab.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth adding that if you don't want it to occupy the terminal (Console is actually a system event logging tool on Mac) you can specify the -d flag to run it in the background and that you can then stop the containers using docker-compose down?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep good idea, thanks

@KatyTaylor KatyTaylor merged commit e0c8cea into develop Dec 13, 2021
@KatyTaylor KatyTaylor deleted the readme-improvement branch December 13, 2021 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants