Skip to content

DPL-222 Move protocol on baracoda and ss url to config#492

Merged
harrietc52 merged 2 commits intodevelopfrom
remove_hardcoded_protocols
Jan 6, 2022
Merged

DPL-222 Move protocol on baracoda and ss url to config#492
harrietc52 merged 2 commits intodevelopfrom
remove_hardcoded_protocols

Conversation

@harrietc52
Copy link
Copy Markdown
Contributor

@harrietc52 harrietc52 commented Jan 4, 2022

Fix to HTTP #501
Coupled with https://github.com/sanger/deployment/pull/151

ansible-playbook -vD deploy_lighthouse.yml -i environments/uat -e "github_branch=2.21.5-1688158399-develop"

  • Pull out deployment config from update-ss-https-links so this can be deployed seperately https://github.com/sanger/deployment/pull/151
  • Merged into develop
  • Deployed to UAT (Lighthouse UI on http)
  • Deployed to Training (Lighthouse UI on http)
  • Deployed to Prod

Merge in https://github.com/sanger/deployment/pull/151 before deploying

@harrietc52 harrietc52 requested a review from emrojo January 4, 2022 17:17
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 4, 2022

Codecov Report

Merging #492 (5b878ca) into develop (ded48ed) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #492      +/-   ##
===========================================
- Coverage    92.33%   92.33%   -0.01%     
===========================================
  Files           98       98              
  Lines         3248     3247       -1     
  Branches       330      330              
===========================================
- Hits          2999     2998       -1     
  Misses         203      203              
  Partials        46       46              
Impacted Files Coverage Δ
lighthouse/config/defaults.py 100.00% <100.00%> (ø)
lighthouse/helpers/plates.py 93.75% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ded48ed...5b878ca. Read the comment docs.

Copy link
Copy Markdown
Contributor

@emrojo emrojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@harrietc52 harrietc52 merged commit f9f804a into develop Jan 6, 2022
@harrietc52 harrietc52 deleted the remove_hardcoded_protocols branch January 6, 2022 14:05
@harrietc52 harrietc52 changed the title Move protocol on baracoda and ss url to config DPL-222 Move protocol on baracoda and ss url to config Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants