Skip to content

DPL-426: Remove COG UK ID creation#659

Merged
sdjmchattie merged 5 commits intodevelopfrom
dpl-426-remove-cog-uk-id-creation
Oct 18, 2022
Merged

DPL-426: Remove COG UK ID creation#659
sdjmchattie merged 5 commits intodevelopfrom
dpl-426-remove-cog-uk-id-creation

Conversation

@sdjmchattie
Copy link
Copy Markdown
Contributor

@sdjmchattie sdjmchattie commented Oct 12, 2022

Part of #607

@sdjmchattie sdjmchattie self-assigned this Oct 12, 2022
@sdjmchattie sdjmchattie marked this pull request as draft October 12, 2022 17:00
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 12, 2022

Codecov Report

Merging #659 (c64df83) into develop (700f58b) will decrease coverage by 0.27%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #659      +/-   ##
===========================================
- Coverage    93.30%   93.03%   -0.28%     
===========================================
  Files          104      104              
  Lines         3258     3202      -56     
  Branches       260      253       -7     
===========================================
- Hits          3040     2979      -61     
- Misses         173      180       +7     
+ Partials        45       43       -2     
Impacted Files Coverage Δ
...t_properties/definitions/samples_with_cog_uk_id.py 100.00% <ø> (ø)
lighthouse/config/defaults.py 100.00% <ø> (ø)
lighthouse/constants/error_messages.py 100.00% <ø> (ø)
lighthouse/helpers/plates.py 91.57% <ø> (-2.64%) ⬇️
lighthouse/routes/common/cherrypicked_plates.py 91.76% <ø> (-0.46%) ⬇️
lighthouse/constants/fields.py 100.00% <100.00%> (ø)
lighthouse/routes/common/plates.py 86.66% <100.00%> (-1.14%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sdjmchattie sdjmchattie linked an issue Oct 13, 2022 that may be closed by this pull request
6 tasks
@sdjmchattie sdjmchattie marked this pull request as ready for review October 13, 2022 11:38
@sdjmchattie sdjmchattie merged commit 1707828 into develop Oct 18, 2022
@sdjmchattie sdjmchattie deleted the dpl-426-remove-cog-uk-id-creation branch October 18, 2022 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DPL-426 Remove updates for MLWH once all samples arrive via RabbitMQ

2 participants