disable the button for the same request type only#2731
Merged
wendyyang merged 12 commits intoTriomic_Epicfrom Mar 16, 2026
Merged
disable the button for the same request type only#2731wendyyang merged 12 commits intoTriomic_Epicfrom
wendyyang merged 12 commits intoTriomic_Epicfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## Triomic_Epic #2731 +/- ##
================================================
+ Coverage 84.91% 84.94% +0.02%
================================================
Files 502 502
Lines 20615 20619 +4
Branches 377 377
================================================
+ Hits 17506 17515 +9
+ Misses 3106 3101 -5
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
KatyTaylor
reviewed
Mar 9, 2026
KatyTaylor
reviewed
Mar 9, 2026
KatyTaylor
approved these changes
Mar 16, 2026
| labware.all_requests.any?(&:pending?) | ||
| def template_request_type(uuid) | ||
| template = Sequencescape::Api::V2::SubmissionTemplate.find_by(uuid:) | ||
| template.request_type_keys.first |
Collaborator
There was a problem hiding this comment.
I see there's an associated SS PR to update the API here - https://github.com/sanger/sequencescape/pull/5605/changes 👍
So you'll have to release that first / at the same time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Closes #
Changes proposed in this pull request
update disable workflow button condition
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main]- Check story numbers included
- Check for debug code
- Check version