Y26-063 - Quad stamp scan fails when plate has no active requests#2779
Y26-063 - Quad stamp scan fails when plate has no active requests#2779BenTopping merged 5 commits intodevelopfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2779 +/- ##
===========================================
+ Coverage 84.99% 85.00% +0.01%
===========================================
Files 504 504
Lines 20668 20684 +16
Branches 377 378 +1
===========================================
+ Hits 17566 17582 +16
Misses 3099 3099
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| }) | ||
| }) | ||
|
|
||
| it.skip('fails if there are duplicate tubes even when the parent has not been updated', () => { |
There was a problem hiding this comment.
I assume at one point this was dependent on the event but this is no longer the case so this is redundant. It has also been skipped for 7 years.
andrewsparkes
left a comment
andrewsparkes
left a comment
There was a problem hiding this comment.
Looks good, minor question about whether minimum number of requests would ever be more than 1.
| // We can't enforce this check for all multi stamp plates because some may not be the first step of the workflow, | ||
| // and therefore may not have library requests yet. So we make it optional to check if the scanned plates have active library requests. | ||
| if (this.requireActiveLibraryRequests === 'true') { | ||
| validators.push(checkMinCountRequests(1)) |
There was a problem hiding this comment.
I think the minimum number of requests that's acceptable for a scanned plate is always going to be 1, did you think of a scenario where it might be a bigger number?
There was a problem hiding this comment.
Im reusing this method from somewhere else so not 100% sure why it was made to accept a parameter (1). There is another similar method called checkMaxCountRequests(x) which makes more sense to have a parameter so maybe its keeping inline with that.
…e library creation requests
…ve active library requests
… it can be overriden by child components
BenTopping
force-pushed
the
Y26-063-quad-stamp-no-active-requests
branch
from
d302ed4 to
ac68a97
Compare
2 participants
Closes #2728
Changes proposed in this pull request