Y26-093 - Create accessioning notification template#5683
Merged
StephenHulme merged 14 commits intodevelopfrom Apr 16, 2026
Merged
Y26-093 - Create accessioning notification template#5683StephenHulme merged 14 commits intodevelopfrom
StephenHulme merged 14 commits intodevelopfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5683 +/- ##
===========================================
+ Coverage 87.25% 87.28% +0.03%
===========================================
Files 1467 1467
Lines 33155 33155
Branches 3493 3493
===========================================
+ Hits 28928 28938 +10
+ Misses 4206 4196 -10
Partials 21 21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
This is ready for review. Can confirm that it's working as intended after integration testing with the notification service. |
dasunpubudumal
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5631
Changes proposed in this pull request
Is
config/accession/notification-template.mjmlthe best folder for it? Any ideas welcome.Example payload:
{ "fields": { "study_name": "Example Study", "manifest_id": 12345, "samples": [ { "sample_name": "Sample 0", "supplier_sample_name": "Supplier Sample 0", "status_message": "Accessioning failed due to: Invalid country", "path": "http://localhost:3000/samples/0", "failure_groups": ["Invalid country"], }, { "sample_name": "Sample 1", "supplier_sample_name": "Supplier Sample 1", "status_message": "Accessioning failed due to: Invalid country, Invalid gender", "path": "http://localhost:3000/samples/1", "failure_groups": ["Invalid country", "Invalid gender"], }, { "sample_name": "Sample 2", "supplier_sample_name": "Supplier Sample 2", "status_message": "Accessioning failed due to: Invalid country, Invalid gender, Invalid collection date", "path": "http://localhost:3000/samples/2", "failure_groups": [ "Invalid country", "Invalid gender", "Invalid collection date", ], }, { "sample_name": "Sample 3", "supplier_sample_name": "Supplier Sample 3", "status_message": "Accessioning failed due to: Invalid country, Invalid gender, Invalid collection date, Provided accession number not found", "path": "http://localhost:3000/samples/3", "failure_groups": [ "Invalid country", "Invalid gender", "Invalid collection date", "Provided accession number not found", ], }, ...Example screenshot:
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main]- Check story numbers included
- Check for debug code
- Check version