Skip to content

Y26-093 - Create accessioning notification template#5683

Merged
StephenHulme merged 14 commits intodevelopfrom
y26-093-add-accessioning-notification-template
Apr 16, 2026
Merged

Y26-093 - Create accessioning notification template#5683
StephenHulme merged 14 commits intodevelopfrom
y26-093-add-accessioning-notification-template

Conversation

@StephenHulme
Copy link
Copy Markdown
Contributor

@StephenHulme StephenHulme commented Apr 10, 2026

Closes #5631

Changes proposed in this pull request

  • Creates a template (inspired by the Sequencescape login page) to be used by the notification hub for sending accessioning failure emails
  • Template written in MJML, to be exported to Jinja2, before being compiled into HTML

Is config/accession/notification-template.mjml the best folder for it? Any ideas welcome.

Example payload:

{
    "fields": {
        "study_name": "Example Study",
        "manifest_id": 12345,
        "samples": [
            {
                "sample_name": "Sample 0",
                "supplier_sample_name": "Supplier Sample 0",
                "status_message": "Accessioning failed due to: Invalid country",
                "path": "http://localhost:3000/samples/0",
                "failure_groups": ["Invalid country"],
            },
            {
                "sample_name": "Sample 1",
                "supplier_sample_name": "Supplier Sample 1",
                "status_message": "Accessioning failed due to: Invalid country, Invalid gender",
                "path": "http://localhost:3000/samples/1",
                "failure_groups": ["Invalid country", "Invalid gender"],
            },
            {
                "sample_name": "Sample 2",
                "supplier_sample_name": "Supplier Sample 2",
                "status_message": "Accessioning failed due to: Invalid country, Invalid gender, Invalid collection date",
                "path": "http://localhost:3000/samples/2",
                "failure_groups": [
                    "Invalid country",
                    "Invalid gender",
                    "Invalid collection date",
                ],
            },
            {
                "sample_name": "Sample 3",
                "supplier_sample_name": "Supplier Sample 3",
                "status_message": "Accessioning failed due to: Invalid country, Invalid gender, Invalid collection date, Provided accession number not found",
                "path": "http://localhost:3000/samples/3",
                "failure_groups": [
                    "Invalid country",
                    "Invalid gender",
                    "Invalid collection date",
                    "Provided accession number not found",
                ],
            },
...

Example screenshot:

screenshot

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

@StephenHulme StephenHulme added the Accessioning Epic in technical roadmap June 2025, relating to improving the accessioning code. label Apr 10, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.28%. Comparing base (1d8a938) to head (b2f8c9f).
⚠️ Report is 17 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5683      +/-   ##
===========================================
+ Coverage    87.25%   87.28%   +0.03%     
===========================================
  Files         1467     1467              
  Lines        33155    33155              
  Branches      3493     3493              
===========================================
+ Hits         28928    28938      +10     
+ Misses        4206     4196      -10     
  Partials        21       21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@StephenHulme
Copy link
Copy Markdown
Contributor Author

This is ready for review. Can confirm that it's working as intended after integration testing with the notification service.

@StephenHulme StephenHulme merged commit f4e7bd4 into develop Apr 16, 2026
28 checks passed
@StephenHulme StephenHulme deleted the y26-093-add-accessioning-notification-template branch April 16, 2026 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Accessioning Epic in technical roadmap June 2025, relating to improving the accessioning code.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Y26-093 - As a TL (Tom) I would like to create an email notification template for accessioning failures to be used with the Notification Service

2 participants