Skip to content

Bugfix/csv row check#58

Merged
emrojo merged 3 commits intomasterfrom
bugfix/csv-row-check
May 27, 2020
Merged

Bugfix/csv row check#58
emrojo merged 3 commits intomasterfrom
bugfix/csv-row-check

Conversation

@pjvv
Copy link
Contributor

@pjvv pjvv commented May 27, 2020

Closes #57

Changes proposed in this pull request:

  • remove check for CSV rows
  • set default for tube rack size

@codecov
Copy link

codecov bot commented May 27, 2020

Codecov Report

Merging #58 into master will increase coverage by 0.68%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
+ Coverage   84.12%   84.81%   +0.68%     
==========================================
  Files          10       10              
  Lines         315      316       +1     
  Branches       36       35       -1     
==========================================
+ Hits          265      268       +3     
+ Misses         41       40       -1     
+ Partials        9        8       -1     
Impacted Files Coverage Δ
wrangler/exceptions.py 78.72% <ø> (+0.15%) ⬆️
wrangler/blueprints/labware.py 100.00% <100.00%> (ø)
wrangler/constants.py 100.00% <100.00%> (ø)
wrangler/helpers/general_helpers.py 100.00% <100.00%> (ø)
wrangler/helpers/labware_helpers.py 78.12% <100.00%> (+0.70%) ⬆️
wrangler/helpers/rack_helpers.py 100.00% <100.00%> (ø)
wrangler/utils.py 63.63% <100.00%> (+8.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 191a977...3ad36c5. Read the comment docs.

@pjvv pjvv requested a review from emrojo May 27, 2020 14:42
@pjvv pjvv linked an issue May 27, 2020 that may be closed by this pull request
@emrojo emrojo merged commit 870d174 into master May 27, 2020
@emrojo emrojo deleted the bugfix/csv-row-check branch May 27, 2020 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GPL-500 BUG - remove check for rows in CSV

2 participants