Conversation
|
Claude finished @binoy14's task in 1m 2s —— View job PR Review
Issues Found1. Path construction incorrect after fileURLToPath (index.js:14) The code joins // Line 13-14
const cliPkgDir = fileURLToPath(await moduleResolve('@sanity/cli/package.json', import.meta.url))
const cliDir = join(cliPkgDir, '..')This creates a path like 2. Variable naming confusion (index.js:13) Variable Fix: import {dirname} from 'node:path'
const cliPkgPath = fileURLToPath(await moduleResolve('@sanity/cli/package.json', import.meta.url))
const cliDir = dirname(cliPkgPath)
const pJson = await readFile(cliPkgPath, 'utf8') |
132b8a0 to
a1b95f7
Compare
a1b95f7 to
edbdffb
Compare
Coverage Report
File CoverageNo changed files found. |
rexxars
left a comment
There was a problem hiding this comment.
Could likely benefit from a bit more explicit path resolution here (eg using dirname and resolve() etc), but since it's not going to be printed it's not the end of the world.
|
I'll do a followup |

Uh oh!
There was an error while loading. Please reload this page.