fix(create-sanity): make path lookup more resistent#304
Merged
Conversation
|
Claude finished @binoy14's task in 52s —— View job Review Complete
Issues FoundTypo in PR title (packages/create-sanity/index.js) Missing test coverage (packages/create-sanity/index.js) |
Coverage Report
File CoverageNo changed files found. |
binoy14
requested review from
mttdnt and
rexxars
and removed request for
a team
rexxars
approved these changes
Jan 22, 2026
binoy14
deleted the
01-16-fix_create-sanity_make_path_lookup_more_resistent
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use built in node primitives to lookup path and resolve the path making it less error prone. Existing tests should suffice