Conversation
The hourly scheduled E2E workflow already exercises the latest published sanity CLI, and npm cache propagation means this post-release trigger isn't reliably testing what was just published. Drop it and rely on the scheduled run instead.
|
This change is part of the following stack: Change managed by git-spice. |
|
Claude finished @binoy14's task in 26s —— View job ReviewNo issues found.
The removal is clean and the reasoning is sound. The |
📦 Bundle Stats —
|
| Metric | Value | vs main (cb1e19a) |
|---|---|---|
| Internal (raw) | 2.1 KB | - |
| Internal (gzip) | 799 B | - |
| Bundled (raw) | 10.94 MB | - |
| Bundled (gzip) | 2.05 MB | - |
| Import time | 850ms | +26ms, +3.1% |
bin:sanity
| Metric | Value | vs main (cb1e19a) |
|---|---|---|
| Internal (raw) | 975 B | - |
| Internal (gzip) | 460 B | - |
| Bundled (raw) | 9.84 MB | - |
| Bundled (gzip) | 1.77 MB | - |
| Import time | 2.01s | +54ms, +2.8% |
🗺️ View treemap · Artifacts
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
📦 Bundle Stats — @sanity/cli-core
Compared against main (cb1e19a5)
| Metric | Value | vs main (cb1e19a) |
|---|---|---|
| Internal (raw) | 93.1 KB | - |
| Internal (gzip) | 21.9 KB | - |
| Bundled (raw) | 21.62 MB | - |
| Bundled (gzip) | 3.42 MB | - |
| Import time | 799ms | +4ms, +0.6% |
🗺️ View treemap · Artifacts
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
📦 Bundle Stats — create-sanity
Compared against main (cb1e19a5)
| Metric | Value | vs main (cb1e19a) |
|---|---|---|
| Internal (raw) | 976 B | - |
| Internal (gzip) | 507 B | - |
| Bundled (raw) | 50.7 KB | - |
| Bundled (gzip) | 12.6 KB | - |
| Import time | ❌ ChildProcess denied: node | - |
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit fa2919a. Configure here.
| cancel-in-progress: false | ||
|
|
||
| permissions: | ||
| actions: write # for gh workflow run in post-release |
There was a problem hiding this comment.
Job output publishedPackages is now unused
Low Severity
The release job's publishedPackages output is now dead code. Its only downstream consumer was the removed post-release E2E trigger step; the Summary step references the step-level output (steps.changesets.outputs.publishedPackages) directly, and the post-release job only reads needs.release.outputs.published. Leaving this orphaned output adds unnecessary noise to the workflow definition.
Reviewed by Cursor Bugbot for commit fa2919a. Configure here.
cngonzalez
left a comment
cngonzalez
left a comment
There was a problem hiding this comment.
lgtm! also seems like the cursor bot's review is wrong since we echo PUBLISHED_PACKAGES but what do I know
2 participants
Description
Removes the post-release step in
release.ymlthat triggerse2e-scheduled.ymlafter publishing.The hourly scheduled E2E workflow already runs against
sanity@latest, so it will catch any post-release breakage on the next cron tick. Triggering it immediately after publish is also unreliable — npm cache propagation means the just-published version isn't always served bynpm install sanity@latestfor a short window, so the immediate run can fail or test the previous version.Also drops the now-unused
actions: writepermission that was only needed forgh workflow run.What to review
.github/workflows/release.yml—post-releasejob no longer dispatchese2e-scheduled.yml, and the workflow'sactions: writepermission is removed.Testing
CI-only change. The hourly
e2e-scheduled.ymlcron continues to provide coverage of the published CLI.Note
Low Risk
Low risk CI-only change that removes an automated workflow dispatch and reduces required GitHub Actions permissions; the main impact is losing immediate post-release E2E coverage.
Overview
Stops the release workflow from dispatching
e2e-scheduled.ymlafter publishing by removing the post-release E2E trigger step.Also drops the workflow-level
actions: writepermission that was only required to rungh workflow run.Reviewed by Cursor Bugbot for commit fa2919a. Bugbot is set up for automated code reviews on this repo. Configure here.