fix(workbench): add __mf__temp directory to .gitignore#1028
fix(workbench): add __mf__temp directory to .gitignore#1028gu-stav merged 3 commits intofeat/workbenchfrom
__mf__temp directory to .gitignore#1028Conversation
📦 Bundle Stats —
|
| Metric | Value | vs feat/workbench (22f7caf) |
|---|---|---|
| Internal (raw) | 2.1 KB | - |
| Internal (gzip) | 799 B | - |
| Bundled (raw) | 10.94 MB | - |
| Bundled (gzip) | 2.05 MB | - |
| Import time | 824ms | +11ms, +1.4% |
bin:sanity
| Metric | Value | vs feat/workbench (22f7caf) |
|---|---|---|
| Internal (raw) | 975 B | - |
| Internal (gzip) | 460 B | - |
| Bundled (raw) | 9.84 MB | - |
| Bundled (gzip) | 1.77 MB | - |
| Import time | 2.29s | +12ms, +0.5% |
🗺️ View treemap · Artifacts
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
📦 Bundle Stats — @sanity/cli-core
Compared against feat/workbench (22f7cafe)
| Metric | Value | vs feat/workbench (22f7caf) |
|---|---|---|
| Internal (raw) | 95.5 KB | - |
| Internal (gzip) | 22.5 KB | - |
| Bundled (raw) | 21.62 MB | - |
| Bundled (gzip) | 3.42 MB | - |
| Import time | 784ms | -1ms, -0.2% |
🗺️ View treemap · Artifacts
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
📦 Bundle Stats — create-sanity
Compared against feat/workbench (22f7cafe)
| Metric | Value | vs feat/workbench (22f7caf) |
|---|---|---|
| Internal (raw) | 976 B | - |
| Internal (gzip) | 507 B | - |
| Bundled (raw) | 50.7 KB | - |
| Bundled (gzip) | 12.6 KB | - |
| Import time | ❌ ChildProcess denied: node | - |
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
Coverage Delta
Comparing 39 changed files against main @ Overall Coverage
|
f550a64 to
40985a7
Compare
|
Claude finished @gu-stav's task in 1m 17s —— View job Review
Changeset summary is inaccurate
Suggested: Fixture gitignore is inconsistent with the template
|
|
it'd be nice if we could avoid having this at the root of projects. iirc its set from the vite plugin, should we look into adding a way to change this filePath upstream do you think? |
|
@joshuaellis Turns out it wasn't hard to add it there: module-federation/vite#670 Since it will take a while to get this merged and updated (the HMR implementation has since been done in the Vite plugin) I'm wondering if we should merge this and revert once it has landed? |
Sure, i think we should be very careful about introducing the HMR behaviour in and be extra vigilant it works as intended before shipping, |
|
ALso need to write a follow ticket to revert this change when we do the update |
|
@claude add an issue to the Dashboard 2.0 project, to revert the above change. |
|
Claude finished @gu-stav's task in 3m 1s —— View job Tasks
I was unable to create the issue — To create the issue manually, you can use this pre-filled link: Then add the created issue to the Dashboard 2.0 project from the issue's sidebar. If you'd like me to retry with approved permissions, you can add |
Description
Module federation still generates the
__mf__tempdirectory in the root of the bootstrapped application when runningsanity init, so we need to add it to the gitignore file.I've added it unconditionally, because if a user would enable module-federation later, it is already ignored.
Note
Low Risk
Small, template-only change plus a matching test assertion; no runtime logic changes beyond the generated
.gitignorecontents.Overview
Bootstrapped projects from
sanity initwill now ignore the module federation temporary directory by adding.__mf__temp/to the shared.gitignoretemplate.The federation init test is updated to assert the generated
.gitignorecontains this entry, and a changeset is added to ship the CLI patch release.Reviewed by Cursor Bugbot for commit f9f7345. Bugbot is set up for automated code reviews on this repo. Configure here.