Conversation
|
Claude finished @dcilke's task in 1m 36s —— View job Review
Issues1. Missing changeset (required) This PR adds a new user-facing CLI flag — a runtime behavior change — but no Add ---
"@sanity/cli": patch
---
Add `--no-strict-asset-verification` flag to `sanity dataset export` to continue exports when an asset fails hash/content-length verification.2. Flag description has awkward double-negative — "Skip aborting the export when an asset fails…" is hard to parse (skip-abort = continue). The parenthetical also doesn't match the style of other flag descriptions in this file (none use parentheticals). Suggested rewording: description: "Continue the export when an asset fails hash or content-length verification (logs a warning instead of aborting)",Or, even tighter and consistent with sibling flags: description: "Do not abort the export when an asset fails hash or content-length verification",3. New flag not surfaced in Other notable flags ( Notes (no action needed)
|
📦 Bundle Stats —
|
| Metric | Value | vs main (dafed5c) |
|---|---|---|
| Internal (raw) | 2.1 KB | - |
| Internal (gzip) | 799 B | - |
| Bundled (raw) | 10.97 MB | - |
| Bundled (gzip) | 2.06 MB | - |
| Import time | 850ms | +3ms, +0.4% |
bin:sanity
| Metric | Value | vs main (dafed5c) |
|---|---|---|
| Internal (raw) | 1023 B | - |
| Internal (gzip) | 486 B | - |
| Bundled (raw) | 9.84 MB | - |
| Bundled (gzip) | 1.77 MB | - |
| Import time | 1.98s | +11ms, +0.6% |
🗺️ View treemap · Artifacts
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
📦 Bundle Stats — @sanity/cli-core
Compared against main (dafed5c3)
| Metric | Value | vs main (dafed5c) |
|---|---|---|
| Internal (raw) | 96.3 KB | - |
| Internal (gzip) | 22.7 KB | - |
| Bundled (raw) | 21.61 MB | - |
| Bundled (gzip) | 3.42 MB | - |
| Import time | 791ms | -13ms, -1.6% |
🗺️ View treemap · Artifacts
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
📦 Bundle Stats — create-sanity
Compared against main (dafed5c3)
| Metric | Value | vs main (dafed5c) |
|---|---|---|
| Internal (raw) | 908 B | - |
| Internal (gzip) | 483 B | - |
| Bundled (raw) | 931 B | - |
| Bundled (gzip) | 491 B | - |
| Import time | ❌ ChildProcess denied: node | - |
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
Coverage Delta
Comparing 1 changed file against main @ Overall Coverage
|
|
@claude address the 3 review findings in a new commit |
|
Claude finished @runeb's task in 2m 5s —— View job Addressed review findings in
|
…n and add example Co-authored-by: Rune Botten <runeb@users.noreply.github.com>
Adds a new flag
--no-strict-asset-verificationtosanity dataset exportto disable strict validation of asset hashes.Note
Low Risk
CLI flag plumbing and dependency bump only; default export behavior remains strict verification unless the flag is set.
Overview
Adds
--no-strict-asset-verificationtosanity dataset exportso exports can continue when downloaded assets fail hash or content-length checks. By default,strictAssetVerificationstaystrueand is passed through to@sanity/export(bumped to ^6.2.0).The command wires the new oclif flag, documents it in examples, and extends tests to assert the option is forwarded to
exportDataset.Reviewed by Cursor Bugbot for commit 477c236. Bugbot is set up for automated code reviews on this repo. Configure here.